Bugs/Issues after upgrade to XF2.1

[GasBandit]

I think I found all the old files still on the server in /styles/dark/ratings (and a couple in just /styles). I can't work on it right now though.

 

[Dave]

I'll look at them.

 

[Bubble181]

Can i just point out that, since the reactions are gone, the forum is lightning fast for me?
I mean, maybe not "lightning" but, not "have to open 10 tabs at once, go do something else, come back to read them"anymore, but just "click, open the thread, read, go back, read another".
Perhaps my massive amount of reactions was what was slowing everything down for me?

 

[Dave]

Okay so they aren't working like I thought they were. They show up but give an error if you try and use one.

InvalidArgumentException: No reaction handler for 'post' in src/XF/Repository/Reaction.php at line 314

1. XF\Repository\Reaction->getReactionHandler() in src/XF/Repository/Reaction.php at line 165
2. XF\Repository\Reaction->insertReaction() in src/XF/Repository/LikedContent.php at line 69
3. XF\Repository\LikedContent->insertLike() in src/addons/ThemeHouse/Reactions/Entity/ReactedContent.php at line 143
4. ThemeHouse\Reactions\Entity\ReactedContent->toggleLike() in src/addons/ThemeHouse/Reactions/Entity/ReactedContent.php at line 93
5. ThemeHouse\Reactions\Entity\ReactedContent->_postSave() in src/XF/Mvc/Entity/Entity.php at line 1208
6. XF\Mvc\Entity\Entity->save() in src/addons/ThemeHouse/Reactions/Repository/ReactedContent.php at line 101
7. ThemeHouse\Reactions\Repository\ReactedContent->insertReact() in src/addons/ThemeHouse/Reactions/ControllerPlugin/React.php at line 29
8. ThemeHouse\Reactions\ControllerPlugin\React->actionToggleReact() in src/addons/ThemeHouse/Reactions/Pub/Controller/React.php at line 27
9. ThemeHouse\Reactions\Pub\Controller\React->actionReact() in src/XF/Mvc/Dispatcher.php at line 350
10. XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 262
11. XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
12. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
13. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2184
14. XF\App->run() in src/XF.php at line 391
15. XF::runApp() in index.php at line 20

 

[GasBandit]

And something tells me this isn't intended behaviour eitherView attachment 32774

Fixed this.

 

[Dave]

Fixed this.

Maybe.

 

[Dave]

removed #1 as it SHOWED but was giving errors if you tried to USE it. Loaded #2 and it looks like it'll work, but the Admin panel that allows you to add new reactions is missing. Ugh.

 

[Dave]

Fuck it. Removed them both until I get a dev on the line.

 

[Bubble181]

Wait, the one we had 5 minutes ago that was giving 5-6 different emojis was working fine (from a user standpoint). You turned this one on and everything's already slowing down again

 

[GasBandit]

Maybe.

It miiiiight have been something I broke the day before yesterday -_-... changed it back, and it went back to how it was supposed to be.

 

[Sparhawk]

Nestled in those thousands of error messages were some TapaTalk errors. Is anyone still using TapaTalk?

Yes, I use it, but switch between desktop and TT depending on where I'm at.

 

[Dave]

Yes, I use it, but switch between desktop and TT depending on where I'm at.

Okay. We are getting TapaTalk errors. I was going to just get rid of it, but I guess I'll try and fix it.

 

[Dei]

Yes, I use it, but switch between desktop and TT depending on where I'm at.

Okay. We are getting TapaTalk errors. I was going to just get rid of it, but I guess I'll try and fix it.

In almost all cases, as someone who used Tapatalk for a little bit, I think your mobile internet browser does a better job than Tapatalk.

 

[DarkAudit]

In almost all cases, as someone who used Tapatalk for a little bit, I think your mobile internet browser does a better job than Tapatalk.

This. The only reason I keep tapatalk around is the notifications when someone quotes a post.

 

[PatrThom]

This. The only reason I keep tapatalk around is the notifications when someone quotes a post.

Don't the alerts already do that? And @mentions , too?

--Patrick

 

[DarkAudit]

Don't the alerts already do that? And @mentions , too?

--Patrick

Not on the notification screen, AFAIK.

 

[PatrThom]

I mean, when I log into the forum, the bell icon in the forum's menu bar will show how many notifications I have--quotes, mentions, likes*, etc.

--Patrick
*well, not exactly as before for likes.

 

[Dei]

I mean, when I log into the forum, the bell icon in the forum's menu bar will show how many notifications I have--quotes, mentions, likes*, etc.

--Patrick
*well, not exactly as before for likes.

I think he means push notifications.

 

[DarkAudit]

I mean, when I log into the forum, the bell icon in the forum's menu bar will show how many notifications I have--quotes, mentions, likes*, etc.

--Patrick
*well, not exactly as before for likes.

We're talking about two different things. Tapatalk gives me alerts on my phone's notification screen without ever opening the phone itself.

 

[Dei]

Some of us turn every notification our phone wants to give us off because they are annoying, so don't always remember that some people like having them.

 

[PatrThom]

We're talking about two different things. Tapatalk gives me alerts on my phone's notification screen without ever opening the phone itself.

Yeah, that’s “push notifications.”

—Patrick

 

[DarkAudit]

Some of us turn every notification our phone wants to give us off because they are annoying, so don't always remember that some people like having them.

I'm in that unique situation where most of those notifications are when I'm asleep with the ringer off. So I just have to scroll through them later that night.

 

[Dave]

Styles are fixed. The first time it will load slowly as it caches, but after that it'll be smooth.

 

[Dei]

I'm in that unique situation where most of those notifications are when I'm asleep with the ringer off. So I just have to scroll through them later that night.

I don't know if it's worth keeping Tapatalk just for push notifications. If you leave HF open in your browser before you go to bed, you can just click the bell when you wake up.

 

[Dave]

I think XF2.x HAS push notifications.

 

[Dave]

Okay, so XF2.X DOES have push notifications, but that requires PHP 7.1.0 or above. We are currently using PHP 5.6.40.

So I would need to update the PHP version. Which I can do from the WHM, but I've never done it before and I don't know what effect it would have.

Anyone familiar with PHP know what would happen?

 

[evilmike]

It looks like when the site shifts from desktop to mobile resolution, the link that gets retained on the menu is 'what's new' and not 'new posts'. Is it possible to change this?

 

[Dave]

And, of course, while researching I get this:

Warning

: Your system’s PHP version has reached EOL. We recommend that you update to a supported version of PHP.

So I guess I HAVE to upgrade.

 

[Dave]

It looks like when the site shifts from desktop to mobile resolution, the link that gets retained on the menu is 'what's new' and not 'new posts'. Is it possible to change this?

I'll work on that.

 

[evilmike]

And, of course, while researching I get this:




So I guess I HAVE to upgrade.

The only experience I have with upgrading PHP is with a WordPress site. When it happened on there, it seemed painless.

 

[Bubble181]

It looks like when the site shifts from desktop to mobile resolution, the link that gets retained on the menu is 'what's new' and not 'new posts'. Is it possible to change this?

Was the very first thing I mentioned

 

[Dave]

The PHP version is already loaded on our server, I just have to change it to that. The problem is it requires a reboot.

 

[Dave]

And it still says we are on the old version of PHP. Even after the reboot. So fuck.

 

[PatrThom]

Ok, so for whatever reason, when I sit on the "Streams" page, my browser's memory usage goes up to anywhere between 2.5GB and 4.5GB YES REALLY.

It seems to cycle, that is it starts at about 2.5GB, and then climbs until it hits around 4.5GB, then it falls back down to 2.5GB, repeat.

--Patrick

 

[Dave]

Hmmm. Maybe there's an update for the addon. But I think I'm at the latest & greatest.